Ticket #717 (reopened defect)

Opened 6 months ago

Last modified 18 hours ago

Parser 2 unit tests fail with timeout

Reported by: www.google.com/accounts/o8/id?id=aitoawllwiulutkaj53jt5cpsokimbe8rdgk9ry Owned by: services.mozilla.com/openid/jono
Priority: blocker Milestone:
Component: builtin-commands Keywords: try-to-reproduce
Cc:

Description

Ubiquity previews are not displaying correctly for some users. It's got a white background and is not showing the full preview. This happened on all commands on both Firefox 3 and 3.5. Bug was identified while running Mac OSX 10.5.

Attachments

patch717.diff (1.1 kB) - added by www.google.com/accounts/o8/id?id=aitoawllwiulutkaj53jt5cpsokimbe8rdgk9ry 6 months ago.
this fixes the bug for me
ue_white.png (20.4 kB) - added by heatherpedia.myopenid.com 6 months ago.
Display of Ubiquity Evolved
sim_white.png (32.0 kB) - added by heatherpedia.myopenid.com 6 months ago.
Simpliquity with the rendering bug
sim_black.png (72.8 kB) - added by heatherpedia.myopenid.com 6 months ago.
Simpliquity with the background changed to black

Change History

Changed 6 months ago by www.google.com/accounts/o8/id?id=aitoawllwiulutkaj53jt5cpsokimbe8rdgk9ry

this fixes the bug for me

Changed 6 months ago by heatherpedia.myopenid.com

  • keywords try-to-reproduce added; try_to_reproduce removed

Confirmed for me in the source version using Firefox 3.10.0 on Mac OS 10.5.6. I see two problems:

1. When using Simpliquity and Ubiquity Evolved, the background on the preview is white. (See attached pictures)

2. When I change the background from transparent to black in Simpliquity (in the body element for the preview), the preview box extends beyond where it is supposed to. (See attached picture)

Changed 6 months ago by heatherpedia.myopenid.com

Display of Ubiquity Evolved

Changed 6 months ago by heatherpedia.myopenid.com

Simpliquity with the rendering bug

Changed 6 months ago by heatherpedia.myopenid.com

Simpliquity with the background changed to black

Changed 6 months ago by services.mozilla.com/openid/jono

  • status changed from new to closed
  • resolution set to fixed

I replicated the problem using parser 1 in firefox 3.5b4. Applied Brandon's patch in 52da186771b0 which fixed the problem for me too.

Changed 6 months ago by blur.myopenid.com

  • status changed from closed to reopened
  • resolution deleted

I think that fix introduces a security regression - the docs say that dynamic changes to the type attribute aren't picked up.

From https://developer.mozilla.org/En/Displaying_web_content_in_an_extension_without_security_issues:

Note: Dynamic changes of the "type" attribute have no effect, the frame type is read out when the frame element is inserted into the document and never again. So the usual rule is: don’t change the value of the "type" attribute. But if you really have to do this, you will also have to remove the frame element from the document and insert it back.

Reopening until its confirmed either way.

Changed 6 months ago by blur.myopenid.com

A clarification from my above comment: This would mean that the preview document is always running with chrome privileges, not as content as intended.

Changed 6 months ago by heatherpedia.myopenid.com

Just to be a pain in the ass, I am also still getting the big white box where the preview should be bug even with Brendan's patch. (I'm on Firefox 3.0.10, which may be the difference)

Changed 6 months ago by brandonpung.myopenid.com

Thanks for bringing this to my attention heather. I checked and sure enough the white box has reappeared in Firefox 3.0.10. I'll look into it =)

Changed 5 months ago by services.mozilla.com/openid/jono

  • priority changed from critical to blocker

Changed 5 months ago by services.mozilla.com/openid/jono

I can replicate this in firefox 3.0.11.

Changed 5 months ago by services.mozilla.com/openid/jono

  • summary changed from Preview html not displayed correctly to Preview html not displayed correctly in firefox 3.0

Changed 5 months ago by mitcho.com

Changed 5 months ago by mitcho.com

Fixed experimental.css . Please check for unintended consequences.

https://ubiquity.mozilla.com/hg/ubiquity-firefox/rev/4560e15fb7a7

Changed 5 months ago by mitcho.com

I made an attempt at fixing this for default.css too, but this fix kills the transparency so it should only be loaded when needed, i.e. in Fx <3.5 on Mac.

https://ubiquity.mozilla.com/hg/ubiquity-firefox/rev/9b6a2021ac81

Changed 5 months ago by heatherpedia.myopenid.com

I don't think this is related to these changes, but now that my preview works I notice the entire command suggestion display is refreshing on each key press when I'm using both default.css and experimental.css.

Changed 5 months ago by heatherpedia.myopenid.com

Mitcho's commit mostly fixed this. There is still a problem for commands that do a wholesale copy of the html page, like "map".

Changed 5 months ago by heatherpedia.myopenid.com

  • priority changed from blocker to major
  • summary changed from Preview html not displayed correctly in firefox 3.0 to Preview html has chrome privlidges

Changed 5 months ago by heatherpedia.myopenid.com

  • summary changed from Preview html has chrome privlidges to Preview html has chrome privileges
  • milestone deleted

Changed 4 months ago by www.google.com/accounts/o8/id?id=aitoawk8su4aysp7nbwear8_j3i1bdkxdj1jr6c

If you’re a dedicated follower of tiffany co like me. Don't miss the tiffany uk & co. on sale including pendants, necklace, earrings, bracelets on line. tiffanys is the one thing that outlasts the cake, champagne and music. links of london jewelry discount , famous for its sweetie and friendship bracelets.
Christian Audigier designer, ed hardy , is a brand of Christian Audigier, and now are favored in the moderning world as a mark of its nice tatoo.

Changed 3 months ago by www.google.com/accounts/o8/id?id=aitoawmb7ypt5qltmilb20jorxp5ykfismi4sk4

# summary changed from Preview html not displayed correctly in firefox 3.0 to Preview html has chrome privlidges Online Universities | PhD Psychology | Science Degree

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 7 weeks ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 7 weeks ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 7 weeks ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawlb9bmbiqglcp9flmc9_cfigsheyqr1yc0

  • priority changed from major to blocker
  • component changed from user-interface to builtin-commands
  • summary changed from Preview html has chrome privileges to Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

No matter where you choose to buy your Eugenie Wallet
,louis vuitton onlineno matter whether you decide on a replica handbag of Louis Vuitton Eugenie Wallet or the authentic one, Louis Vuitton Multiple Wallet in mind that take your time choosing the bag of your dreams to Multiple Wallet that you have the best possible deal for your money.

Crafted in Monogram Vernis leather, Alma MM, Speedy 30a reinterpretation of an icon, louis vuitton
Louis Vuitton Neverfull MMis revisited for a glamorous look. Louis Vuitton Speedy 30This bag has a double zipper for easy opening and closure, and a padlock for added security.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

We are providing all kinds of louis vuitton handbags, wallets and purses in ourgucci Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of replica handbags today and you will never be disappointed with it.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawkclkx2iowpzwyrxpiaq6wrdn-gz_z3spc

Love this man. Great stuff, great prices, free shipping.louis [[BR]

vuitton] Email him if you cant find what you are looking for and he will look for you. Good customer

service.
SHIPPING- Free!!!!!!!

Changed 18 hours ago by www.google.com/accounts/o8/id?id=aitoawluavlg7nmrcte2uxtc-2v9zbi-1qjrcck

  • summary changed from Firefox won't quit normally w/ Ubiquity enabled, nom noms memory to Parser 2 unit tests fail with timeout

We offer you the men's and ladies' replica watches, designer replica watches, Swiss and UK replicas and other replica watches for sale.

It is true that the replica rolex air king is the most affordable rolex replica watchh, because it lacks any flashy diamonds or expensive gold stylings.

We supply full rage of replicas watches with perfect imitation such as Rolex watches, Breitling watches, and so on.

Note: See TracTickets for help on using tickets.