Ticket #47 (assigned defect)

Opened 16 months ago

Last modified 19 hours ago

Parser 2 unit tests fail with timeout

Reported by: azarask.in/aza Owned by: jonoscript.wordpress.com
Priority: blocker Milestone:
Component: builtin-commands Keywords: try-to-reproduce
Cc:

Description

I have a GMail contact with an email address of "backgroundchecks@…". While typing "check", Ubiquity correctly recognizes that I'm going to use the "check calendar" command. Upon typing anything after "check", Ubiquity automatically switches to the "email" command and assumes that I want to send an email to the "backgroundchecks@…" contact. Also, a list of other possible commands (google check, imdb check, map-it check, ...) is shown in the preview area, and the "check calendar" command is not listed.

I'm guessing this isn't a glitch in the "check calendar" and "email" commands, but a more global 'feature'?

Attachments

checkCal.JPG (23.3 kB) - added by me.yahoo.com/izuzak#1d5d2 16 months ago.
screenshot

Change History

Changed 16 months ago by me.yahoo.com/izuzak#1d5d2

screenshot

Changed 16 months ago by jonoscript.wordpress.com

  • owner changed from varmaa@… to azaaza@…
  • priority changed from major to minor
  • status changed from new to assigned
  • milestone set to ubiquity 0.1 release

This is because the "Check Calendar" command has a nonbreaking space character in the command name, which cannot be typed.

It's a special case of the more general problem of standardizing terminology and of the parser assuming that command names (verbs) will be one word. But the immediate problem can be fixed just by changing the nbsp to a hyphen.

Changed 16 months ago by atul.toolness.com

  • reporter changed from me.yahoo.com/izuzak#1d5d2 to azarask.in/aza

Changed 16 months ago by atul.toolness.com

  • owner changed from azaaza@… to azarask.in/aza

Changed 16 months ago by azarask.in/aza

It appears that the non-breaking space was not the reason for the command name interference. After changing the command names to use hyphen, I still always get the Google command first. My hunch is that it is the date noun-type that is giving us troubles. I'll look into that next.

Changed 16 months ago by jonoscript.wordpress.com

  • owner changed from azarask.in/aza to jonoscript.wordpress.com

Dietrich is having a problem with his custom tagging commands (which he's working on at tagging_cmds.js) that appears to be related to this problem. His "show" command that takes a custom noun-type defined in tagging_cmds.js drops out of the suggestion list when the input is "show ", which makes me think that maybe the custom noun type it expects is always returning false from match(), and maybe DateNounType? is doing the same which would explain why the "Check Calendar" command drops out of the suggestion list.

Also, I'm stealing this bug.

Changed 16 months ago by jonoscript.wordpress.com

  • priority changed from minor to major
  • summary changed from check calendar command interferes with email command to DateNounType (maybe other noun types too) won't accept any input as valid

Changing the name of the bug to better reflect the generality of the problem, and raising the priority, because if this is what I think it is then it's a general problem with the whole NounType? system that will affect lots of commands if not fixed.

Changed 16 months ago by jonoscript.wordpress.com

Um, DateNounType? seems to be using the *builtin* javascript Date object instead of the superior replacement provided by date.js. This doesn't explain all the problems but it does explain why DateNounType? doesn't return anything for input like "Today".

Changed 16 months ago by jonoscript.wordpress.com

  • priority changed from major to minor
  • summary changed from DateNounType (maybe other noun types too) won't accept any input as valid to When you're partway through typing a date, DateNounType won't accept it as valid
  • milestone changed from ubiquity 0.1 release to To Do Later

Actually it seems that just importing date.js in builtinfactories.js solves most of the problem here. I committed this in ff230e1093c8.

But the reason that it was easy to overlook not including date.js has to do with #88, which we really ought to fix in order to prevent stuff like this from happening more often in the future.

There's still a problem with the DateNounType?, and it's a UI issue: date.js parses "today" as a valid date but it doesn't parse "tod", for example. So there are a lot of cases where you type "check" and it's offering "check-calendar" as a completion, but then you start typing the date and DateNounType? looks at your partial input and says "Hey, that's not a date", so check-calendar temporarily disappears from the completion list, until you get a few more characters typed and it suddenly becomes a valid date again and check-calendar reappears.

This is not very humane.

I'm leaving this ticket open but renaming it to reflect this problem and reducing the priority.

Changed 15 months ago by blur.myopenid.com

You're right - its not humane. But its also the correct behaviour (since it isn't valid), until someone can figure out how to auto-suggest dates (which can use many many different formats).

If I remember right, date.js uses a locale table - maybe we can use this as a lookup? Since the main problem seems to be with worded dates, rather than numbers.

Changed 15 months ago by jonoscript.wordpress.com

  • component changed from ubiquity-firefox-core to builtin-commands

Changed 8 months ago by atul.toolness.com

  • milestone deleted

Milestone To Do Later deleted

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

  • keywords try-to-reproduce added
  • priority changed from minor to blocker
  • summary changed from When you're partway through typing a date, DateNounType won't accept it as valid to Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

We are providing all kinds of louis vuitton handbags, wallets and purses in ourgucci Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of replica handbags today and you will never be disappointed with it.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawlb9bmbiqglcp9flmc9_cfigsheyqr1yc0

Welcome to our company, our company Huayi Trade Co.,LTD are good at selling the top quality designer bags (Balenciaga ,Chanel , Chloe' ,Christian Dior ,Dolce&Gabbana , Fendi , Gucci , Hermes , Galliera GM ,Miu Miu , Prada ), they are mirror image bags which are identical to the real onesLouis Vuitton Galliera GM . Our company locates inthe leather town in China, Speedy 25since 2003 we did this business we have won great trust and popularity from our customers from all over the world. We areexpanding our business, any inquiry for wholesale business is warmly welcome, Louis Vuitton Speedy 25just contact us, you can get our prompt reply.We have enlish speaking representative to answer phone call, or we can call you if convenient for you.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawkclkx2iowpzwyrxpiaq6wrdn-gz_z3spc

When the economy became a bit less predictable, more women started looking for ways to make their wedding dresses a little less costly. Some women opted to donate their used wedding dresses to other brides-to-be. Others still choose to cherish this garment, saving it for future daughters or granddaughters to wear in their weddings.

The new shop, designer wedding gowns, is almost directly opposite his existing ready-to-wear and couture boutique, at No. 27, which opened in 1984.

The models this week were nine divorcees who were willing to give their designer wedding dresses major makeovers! The designers had to turn old wedding dress into a hip outfit they “can wear in the next chapter of their lives.”

Changed 2 days ago by www.google.com/accounts/o8/id?id=aitoawm852izcz54zwmty9xw1mxhvvgrd9ygyoo

  • summary changed from Firefox won't quit normally w/ Ubiquity enabled, nom noms memory to Parser 2 unit tests fail with timeout

We provide a variety of Wedding dress gowns according to the measurements your supplied.

A view of the world's longest wedding dresses train made by Zhao Peng to please his ·

Dennis wholesale wedding dress factory would like to thank you for visiting our site and welcome wholesale wedding gowns from us.

Changed 19 hours ago by www.google.com/accounts/o8/id?id=aitoawnbwo_pwhqsqxjjlpefo3uhuhpi55n_b7q

louis vuitton competes directly with such luxury brands as Versace, Hermès, Gucci, Dolce & Gabbana, Burberry, Dior, Chanel, Fendi, Armani, and Prada.

luis vuitton is all about matching with the right outfit so as to appear the right side of classy rather than the wrong side of sexy.

Versace will join existing luxury tenants Prada, louis vuitton , the latter of which is also undergoing an expansion ... "

Note: See TracTickets for help on using tickets.