Ticket #437 (reopened defect)

Opened 12 months ago

Last modified 18 hours ago

Parser 2 unit tests fail with timeout

Reported by: atul.toolness.com Owned by: atul.toolness.com
Priority: blocker Milestone:
Component: builtin-commands Keywords: try-to-reproduce
Cc:

Description

When I enable syntax highlighting on the command editor, I can't type in the editor area and the JS error console logs the following warnings:

Error: CodeMirror is undefined
Source File: chrome://ubiquity/content/editor.html -> resource://ubiquity-scripts/codemirror/js/editor.js
Line: 1048

followed by

Error: this.editor is undefined
Source File: chrome://ubiquity/content/editor.html -> resource://ubiquity-scripts/codemirror/js/codemirror.js
Line: 96

Is anyone else experiencing this problem?

Attachments

codemirror-ff31fix.diff (2.5 kB) - added by freakcers.myopenid.com 12 months ago.
reverses atuls workaround and fixes the editor for FF3.1+

Change History

Changed 12 months ago by atul.toolness.com

This problem doesn't occur in 3.0.4. At the very least, it's only occurring in 3.2a1pre. I can't even get Firebug's console.log() to work in a tab with a chrome URI in 3.2a1pre, so this broken-ness could be due to a bug or change in behavior in 3.2 (or 3.1).

Changed 12 months ago by atul.toolness.com

Aza has 3.1b3pre and it doesn't work there, either.

Changed 12 months ago by atul.toolness.com

  • summary changed from Command editor syntax highlighting is broken to Command editor syntax highlighting is broken in FF 3.1+
  • milestone changed from Ubiquity 0.1.3: Lexivore to Ubiquity 0.2.1 release

Added a workaround for FF3.1b1 and above in a606c9402412 such that syntax highlighting is always disabled and the checkbox isn't shown, but if the user's on FF3.0, it works normally.

Moving this bug out of the 0.1.3 milestone.

Changed 12 months ago by freakcers.myopenid.com

  • milestone changed from Ubiquity 0.2.1 release to Ubiquity 0.1.3: Lexivore

Changed 12 months ago by freakcers.myopenid.com

reverses atuls workaround and fixes the editor for FF3.1+

Changed 12 months ago by fernandotakai.wordpress.com

  • status changed from new to closed
  • resolution set to fixed

Applied the patch on e6580d6815f9

Changed 12 months ago by blur.myopenid.com

  • status changed from closed to reopened
  • resolution deleted

Reopening, as this still has issues due to a security change affecting XPCNativeWrapper. From https://developer.mozilla.org/en/XPCNativeWrapper#Limitations_of_XPCNativeWrapper :

# Using the delete operator on "expando" properties of an XPCNativeWrapper throws a security exception.

Changed 12 months ago by blur.myopenid.com

  • priority changed from major to blocker

Changed 12 months ago by freakcers.myopenid.com

(Why weren't I allowed to reopen this? :-S)

The changes brought on by FF3.1b2 were more substantial than I had figured, so my patch only fixes *some* of the problems - not all...

The breakage is related to bug #425153 and is basically caused by us loading the chrome url in a tab (which makes it content, and everything is wrapped in a XPCNativeWrapper)

There are mixed reports as to how well the editor is working, but it is at least broken for some FF3.1b2+ users. In my own build, the cursor jumps to wrong position each time a change is detected (and with undoDelay set to 100ms, that's pretty often)

Changed 11 months ago by atul.toolness.com

Hmm, we may just want to revert FreakCERS' patch and re-commit my original workaround that disables the editor on 3.1... Any other ideas?

Changed 11 months ago by atul.toolness.com

  • priority changed from blocker to major
  • milestone changed from Ubiquity 0.1.3: Lexivore to To Do Later

Because of the limitations of FreakCERS' patch, I've undone it and re-applied my original workaround in e20a0d26619e. Moving this bug off the 0.1.3 milestone and lowering its priority.

Changed 11 months ago by blur.myopenid.com

In the long run, I'd like to use something other than CodeMirror? (too many problems, including performance issues). I've mentioned Diavolo before, but that requires someone writing a JavaScript? grammar for it. An option I'd like to pursue is porting Komodo's Scintilla-based editor.

Changed 8 months ago by atul.toolness.com

  • milestone deleted

Milestone To Do Later deleted

Changed 5 months ago by mitcho.com

Was there a resolution here?

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 7 weeks ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawlb9bmbiqglcp9flmc9_cfigsheyqr1yc0

  • keywords try-to-reproduce added
  • priority changed from major to blocker
  • component changed from ubiquity-firefox-core to builtin-commands
  • summary changed from Command editor syntax highlighting is broken in FF 3.1+ to Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

No matter where you choose to buy your Eugenie Wallet
,louis vuitton onlineno matter whether you decide on a replica handbag of Louis Vuitton Eugenie Wallet or the authentic one, Louis Vuitton Multiple Wallet in mind that take your time choosing the bag of your dreams to Multiple Wallet that you have the best possible deal for your money.

Crafted in Monogram Vernis leather, Alma MM, Speedy 30a reinterpretation of an icon, louis vuitton
Louis Vuitton Neverfull MMis revisited for a glamorous look. Louis Vuitton Speedy 30This bag has a double zipper for easy opening and closure, and a padlock for added security.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

We are providing all kinds of louis vuitton handbags, wallets and purses in ourgucci Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of replica handbags today and you will never be disappointed with it.

Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawkclkx2iowpzwyrxpiaq6wrdn-gz_z3spc

Love this man. Great stuff, great prices, free shipping.louis [[BR]

vuitton] Email him if you cant find what you are looking for and he will look for you. Good customer

service.
SHIPPING- Free!!!!!!!

Changed 18 hours ago by www.google.com/accounts/o8/id?id=aitoawluavlg7nmrcte2uxtc-2v9zbi-1qjrcck

  • summary changed from Firefox won't quit normally w/ Ubiquity enabled, nom noms memory to Parser 2 unit tests fail with timeout

If the replicas watch you are about to order really looks great in the picture, you can bet it will look gorgeous on your wrist.

If you order your replica in our store you can be sure this is the best replica watches you may find.

This replica watch has all of the simple elegance of an authentic rolex Air King at a price that’s still only about 10% of the original.

Note: See TracTickets for help on using tickets.