Ticket #275 (accepted defect)

Opened 15 months ago

Last modified 3 weeks ago

Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

Reported by: joetidmarsh.com Owned by: abcdefu.wordpress.com
Priority: blocker Milestone:
Component: builtin-commands Keywords: try-to-reproduce
Cc:

Description (last modified by jonoscript.wordpress.com) (diff)

The current auto-complete implementation does not handle verbs containing modifiers in a helpful way (outputs all modifiers names with blank values).

Additionally, large text selections should be represented with a pronoun (this, selection) as the user would input - primarily to ease readability.

Attachments

patch.diff (2.7 kB) - added by joetidmarsh.com 15 months ago.
Initial patch
verbtypes.diff (1.7 kB) - added by joetidmarsh.com 14 months ago.
Fixed bug introduced at revision 3f26f863d2f9. An incorrect conditional scope had been introduced - breaking functionality. Formatting for conditionals has also been corrected.

Change History

Changed 15 months ago by joetidmarsh.com

Initial patch

  Changed 15 months ago by azarask.in/aza

  • milestone changed from Ubiquity 0.1.2: Raging Stream to Ubiquity 0.1.3: Lexivore

  Changed 15 months ago by joetidmarsh.com

  • summary changed from Improve auto-complete. to Improve auto-complete to intelligently handle arguments and selections.

  Changed 14 months ago by abcdefu.wordpress.com

  • owner changed from atul.toolness.com to abcdefu.wordpress.com
  • status changed from new to accepted

  Changed 14 months ago by abcdefu.wordpress.com

  • milestone changed from Ubiquity 0.1.3: Lexivore to Ubiquity 0.1.2: Raging Stream

follow-up: ↓ 8   Changed 14 months ago by abcdefu.wordpress.com

Patch applied in 3f26f863d2f9. But there's still more to do for autocompletion (specifically, if you ubiq "twitter this", pick the second suggestion and tab, it does not work as expected; it should make the first suggestion "this" rather than the selection). So, I'm leaving it open for 0.1.3.

  Changed 14 months ago by abcdefu.wordpress.com

  • priority changed from trivial to major
  • milestone changed from Ubiquity 0.1.2: Raging Stream to Ubiquity 0.1.3: Lexivore

Changed 14 months ago by joetidmarsh.com

Fixed bug introduced at revision 3f26f863d2f9. An incorrect conditional scope had been introduced - breaking functionality. Formatting for conditionals has also been corrected.

  Changed 14 months ago by jonoscript.wordpress.com

  • description modified (diff)

Imported joetidmarsh.com's patch, tested it, and committed it in 74a2bf86c072. It fixes the bugs introduced at 3f26f863d2f9.

in reply to: ↑ 5   Changed 14 months ago by joetidmarsh.com

Replying to abcdefu.wordpress.com:

Patch applied in 3f26f863d2f9. But there's still more to do for autocompletion (specifically, if you ubiq "twitter this", pick the second suggestion and tab, it does not work as expected; it should make the first suggestion "this" rather than the selection). So, I'm leaving it open for 0.1.3.

Abi, I believe the specific problem you refer to lies within the augment suggestion generator; but I do agree that it can sometimes make the auto-completion confusing. However, I would like to invoke some discussion regarding this feature and its behaviour. FreakCERS did express that the behaviour was not as expected, and I believe that this is something we should correct. I did implement this with no prior experience with similar products such as quicksilver, therefore someone else may know how to better handle the behaviour.

Finally, within the current version (committed in rev.74a2bf86c072) a valid user-selection is swapped with the term “selection” to promote readability. With the introduction of Jono’s localization API, this value will have to be determined from the user’s language preference.

  Changed 12 months ago by atul.toolness.com

  • milestone changed from Ubiquity 0.1.3: Lexivore to Ubiquity 0.1.4: Not Named

  Changed 8 months ago by atul.toolness.com

  • milestone deleted

Milestone Ubiquity 0.2.1 release deleted

  Changed 6 months ago by www.google.com/accounts/o8/id?id=aitoawmksw2hfhb15eidvqpbtaomjh6rfhxyubq

This works ok for me.. but It probably needs feedback. Nike Air Yeezy Shoes

  Changed 5 months ago by mitcho.com

  • keywords try-to-reproduce added

Was there a resolution to this ticket? Adding "try-to-reproduce".

  Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

  • priority changed from major to blocker
  • type changed from enhancement to defect
  • component changed from ubiquity-firefox-core to builtin-commands
  • summary changed from Improve auto-complete to intelligently handle arguments and selections. to Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

We are providing all kinds of <a href="http://www.byreplica.com/">louis vuitton</a> handbags, wallets and purses in our<a href="http://www.byreplica.com/">gucci</a> Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of <a href="http://www.byreplica.com/">replica handbags</a> today and you will never be disappointed with it.

Our comapny has been providing quality <a href="http://www.byreplica.com/">luis vuitton</a> replicas with cheap prices for more than 6 years, all our items will arrive in perfect condition to your hand and come with free hassle return and exchange policy.

Your satisfication is guanrateed <a href="http://www.byreplica.com/">louie vuitton</a>and please shop with confidence.

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

We are providing all kinds of [url=http://www.byreplica.com/]louis vuitton/url handbags, wallets and purses in our[url=http://www.byreplica.com/]gucci[/url] Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of [url=http://www.byreplica.com/]replica handbags/url today and you will never be disappointed with it.

Our comapny has been providing quality [url=http://www.byreplica.com/]luis vuitton/url replicas with cheap prices for more than 6 years, all our items will arrive in perfect condition to your hand and come with free hassle return and exchange policy.

Your satisfication is guanrateed [url=http://www.byreplica.com/]louie vuitton/urland please shop with confidence.

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawlb9bmbiqglcp9flmc9_cfigsheyqr1yc0

Welcome to our company, our company Huayi Trade Co.,LTD are good at selling the top quality designer bags (Balenciaga ,Chanel , Chloe' ,Christian Dior ,Dolce&Gabbana , Fendi , Gucci , Hermes , Galliera GM ,Miu Miu , Prada ), they are mirror image bags which are identical to the real onesLouis Vuitton Galliera GM . Our company locates inthe leather town in China, Speedy 25since 2003 we did this business we have won great trust and popularity from our customers from all over the world. We areexpanding our business, any inquiry for wholesale business is warmly welcome, Louis Vuitton Speedy 25just contact us, you can get our prompt reply.We have enlish speaking representative to answer phone call, or we can call you if convenient for you.

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawkclkx2iowpzwyrxpiaq6wrdn-gz_z3spc

When the economy became a bit less predictable, more women started looking for ways to make their wedding dresses a little less costly. Some women opted to donate their used wedding dresses to other brides-to-be. Others still choose to cherish this garment, saving it for future daughters or granddaughters to wear in their weddings.

The new shop, designer wedding gowns, is almost directly opposite his existing ready-to-wear and couture boutique, at No. 27, which opened in 1984.

The models this week were nine divorcees who were willing to give their designer wedding dresses major makeovers! The designers had to turn old wedding dress into a hip outfit they “can wear in the next chapter of their lives.”

Note: See TracTickets for help on using tickets.