Ticket #252 (reopened defect)

Opened 15 months ago

Last modified 3 weeks ago

Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

Reported by: fernandotakai.wordpress.com Owned by: fernandotakai.wordpress.com
Priority: blocker Milestone:
Component: builtin-commands Keywords: try-to-reproduce
Cc: jeremy.laidman@…

Description

Right now, if you try to use the email verb like this: "email this to foo@…", the noun_type_contact does not recognize the email (in fact, it tries to find a contact with that name) and it should as it is a valid email.

Attachments

email.patch (0.5 kB) - added by fernandotakai.wordpress.com 15 months ago.
This patch adds an regex that validates if the email is valid and adds to the suggestion list.

Change History

Changed 15 months ago by fernandotakai.wordpress.com

This patch adds an regex that validates if the email is valid and adds to the suggestion list.

  Changed 15 months ago by jonoscript.wordpress.com

  • status changed from new to closed
  • resolution set to fixed

Patch accepted in dc41e72aaf71

follow-up: ↓ 3   Changed 15 months ago by hyper.to/blog

  • cc c1.dev1@… added

gTLDs can be longer than 4 chars, e.g. .museum, and recent ICANN ruling is that any gTLD can be registered (to be implemented in 2009). See http://en.wikipedia.org/wiki/Top-level_domain .

Also, there are many other characters allowed and in use for the account name part.

Could use the following regexp, which mostly conforms to RFC2822:

(deleted during migration from sqlite to mysql)

I've definitely seen use of plus, dollar and equal signs.

in reply to: ↑ 2   Changed 15 months ago by hyper.to/blog

Yikes, that got munged.

Here it is again:

(deleted during migration from sqlite to mysql)

  Changed 15 months ago by blur.myopenid.com

  • status changed from closed to reopened
  • resolution deleted

Due to the shortcomings of the existing regex, I'm re-opening the ticket.

Also, that revised regex won't work for an internationalized domain name (IDN). Or an internationalized mailbox.

It would be fine if it could be matched against the Punycode format of the IDN, but I'm not sure if Firefox exposes any API for converting between the two formats.

However, since its all just Unicode anyway, the following Unicode ranges should work when added to the existing character ranges:

u00A0-uD7FFuF900-uFDCFuFDF0-uFFEF

Also, I think in the long term we should have the domain name regex put into noun_type_domainname. That way noun_type_contact can rely on noun_type_domainname for validating the domain, and specialize solely on validating the mailbox portion of an email address.

Going further with that idea, noun_type_contact shouldn't be validating email addresses - only known contacts. Instead, it should rely on noun_type_emailaddress, which will use the above regex. Or perhaps have a third noun type that combines noun_type_emailaddress and noun_type_contact. Will need to figure out a naming scheme in that case - possibly noun_type_email_address, noun_type_email_contact, with noun_type_email combining them.

  Changed 13 months ago by fernandotakai.wordpress.com

We could translate this regex to javascript - its compatible to rfc 882 and them create a noun_type_email_address.

  Changed 12 months ago by abcdefu.wordpress.com

  • keywords email added

  Changed 10 months ago by www.google.com/accounts/o8/id?id=aitoawkexd4rfvidlynvt2seg96forifpnj3k58

  • cc jeremy.laidman@… added
  • summary changed from noun_type_contact should accept an valid email as an option to noun_type_contact should accept a valid email as an option

Is it really so important to only ever match a valid email address according to several standards, using a debatable regex? (I don't actually have a problem with the regex itself, but it's already been debated, hence "debatable".) After all, the address is given as a suggestion to a user, who can take it or leave it. My preference would be to let the user type just about anything in, matching /.@./ and let it go. If there's a contact's name with an at sign in it, then that should be in the suggestions list too. Keep the regex simple (and unchanging) and let the user decide if the suggestions are correct.

  Changed 10 months ago by abcdefu.wordpress.com

  • component changed from ubiquity-firefox-core to builtin-commands
  • milestone set to Command Updates

I agree. In fact, I think we should allow any input even if it is not an email. This is because of this situation - say you type "email hi to aasda", if you don't have such a contact in your address book, then Ubiquity basically gives no suggestions. So, the user thinks he's done something wrong. And even if you continue typing "email hi to aasda@g" and this is accepted as valid input, its likely the user won't even try since he doesn't think this is possible.

I should articulate this better but does this reasoning make sense?

Actually, this "no preview shown if nountype is wrong" problem is a Ubiquity-wide problem that needs to be addressed (perhaps by telling the user what they're doing wrong rather than showing no preview or suggestions).

  Changed 8 months ago by atul.toolness.com

  • milestone deleted

Milestone Command Updates deleted

  Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

  Changed 3 months ago by me.yahoo.com/a/fdd90cg9icmsicxvoyjf4zcwm.tm7dh0#f4bbc

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawmtb3gjpkmn8lsxu5paedcc7hdyekstayq

  • keywords try-to-reproduce added; email removed
  • priority changed from minor to blocker
  • type changed from enhancement to defect
  • summary changed from noun_type_contact should accept a valid email as an option to Firefox won't quit normally w/ Ubiquity enabled, nom noms memory

We are providing all kinds of louis vuitton handbags, wallets and purses in ourgucci Online Store, all items of which have the most popular styles and are the newest and at discounted prices.

We also provide helpful shopping guide tips for you to choose and compare our bags and other accessories. Get your sale of replica handbags today and you will never be disappointed with it.

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawlb9bmbiqglcp9flmc9_cfigsheyqr1yc0

Welcome to our company, our company Huayi Trade Co.,LTD are good at selling the top quality designer bags (Balenciaga ,Chanel , Chloe' ,Christian Dior ,Dolce&Gabbana , Fendi , Gucci , Hermes , Galliera GM ,Miu Miu , Prada ), they are mirror image bags which are identical to the real onesLouis Vuitton Galliera GM . Our company locates inthe leather town in China, Speedy 25since 2003 we did this business we have won great trust and popularity from our customers from all over the world. We areexpanding our business, any inquiry for wholesale business is warmly welcome, Louis Vuitton Speedy 25just contact us, you can get our prompt reply.We have enlish speaking representative to answer phone call, or we can call you if convenient for you.

  Changed 3 weeks ago by www.google.com/accounts/o8/id?id=aitoawkclkx2iowpzwyrxpiaq6wrdn-gz_z3spc

When the economy became a bit less predictable, more women started looking for ways to make their wedding dresses a little less costly. Some women opted to donate their used wedding dresses to other brides-to-be. Others still choose to cherish this garment, saving it for future daughters or granddaughters to wear in their weddings.

The new shop, designer wedding gowns, is almost directly opposite his existing ready-to-wear and couture boutique, at No. 27, which opened in 1984.

The models this week were nine divorcees who were willing to give their designer wedding dresses major makeovers! The designers had to turn old wedding dress into a hip outfit they “can wear in the next chapter of their lives.”

  Changed 3 weeks ago by lokiunbound.myopenid.com

  • cc c1.dev1@… removed
Note: See TracTickets for help on using tickets.